Implementation Tasks

Implementation Tasks

• [ ] T1 (P1, human: ~2h / CC: ~15min) — —
  • Surfaced by:
    —
  • Files:
  • Verify:

优先级约定：P1 阻塞 ship；P2 应落在同一分支；P3 是跟进 TODO。若某发现没有可行动任务就不硬造；零发现的小节输出 `_No new tasks from <section>._`。

JSONL 制品用 `jq -nc` 逐任务写入（绝不手写 `echo`/`printf` 拼 JSON）：

```bash
eval "$(~/.claude/skills/gstack/bin/gstack-slug 2>/dev/null)"
TASKS_DIR="${HOME}/.gstack/projects/${SLUG:-unknown}"
mkdir -p "$TASKS_DIR"
TASKS_FILE="$TASKS_DIR/tasks-design-review-$(date +%Y%m%d-%H%M%S).jsonl"
# 每个任务一次 jq -nc 调用：
# --arg phase 'design-review' --arg id "$TASK_ID" --arg priority "$PRIORITY" ...
# --argjson files '["path/a.ts","path/b.ts"]'
# 字段：phase, run_id, branch, commit, id, priority, component, files,
#       effort_human, effort_cc, title, source_finding

零任务时仍要 touch 该文件——空文件语义是"跑了，无发现"，区别于"没跑"。

十二、完成摘要、评审日志与看板

Completion Summary 是固定表格：System Audit、Step 0 初始评分、Pass 1–7 各自的"修前 → 修后"分数、NOT in scope / What already exists / TODOS 提案数、Approved Mockups（生成数/批准数）、加入计划的决策数、总体分 ___/10 → ___/10。若全部 pass ≥8："Plan is design-complete. Run /design-review after implementation for visual QA."

评审落盘（PLAN MODE EXCEPTION — ALWAYS RUN）：

~/.claude/skills/gstack/bin/gstack-review-log '{"skill":"plan-design-review","timestamp":"TIMESTAMP","status":"STATUS","initial_score":N,"overall_score":N,"unresolved":N,"decisions_made":N,"commit":"COMMIT"}'

status 取 "clean"（总分 ≥8 且 0 未解决）否则 "issues_open"。此命令写入 ~/.gstack/，/ship 的评审就绪看板依赖它，跳过会破坏看板。

Review Readiness Dashboard：运行 gstack-review-read 后解析输出，7 天窗口内取每个技能最近一条；Design Review 行取 plan-design-review（完整视觉审计）与 design-review-lite（代码级检查）中较新者，状态后缀 (FULL)/(LITE)。评审分层：Eng Review 是唯一默认强制的 ship 门（可全局 gstack-config set skip_eng_review true 关闭）；CEO / Design / Outside Voice 为可选，从不阻塞 ship；Adversarial Review 对所有 diff 常驻。过期检测对 plan 级行（含 plan-design-review）不适用 worktree 规则——计划级评的是计划文件而非仓库树，维持 7 天新鲜度逻辑，若有 plan_sha256 字段可对比当前计划文件哈希并在不匹配时标注"plan changed since review"。

十三、计划文件评审报告与 EXIT PLAN MODE 门

审查完成后，还要把 ## GSTACK REVIEW REPORT 写进计划文件末尾，让任何读计划的人都能看到评审状态。报告表格按技能固定形态：

## GSTACK REVIEW REPORT

| Review | Trigger | Why | Runs | Status | Findings |
|--------|---------|-----|------|--------|----------|
| Design Review | `/plan-design-review` | UI/UX gaps | {runs} | {status} | score: {initial}/10 → {overall}/10, {decisions} decisions |